Optimize MergeEqInFilterOptimizer by reducing the hash computation of Expression #14732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #14732 +/- ##
============================================
+ Coverage 61.75% 63.82% +2.07%
- Complexity 207 1607 +1400
============================================
Files 2436 2703 +267
Lines 133233 150651 +17418
Branches 20636 23268 +2632
============================================
+ Hits 82274 96157 +13883
- Misses 44911 47305 +2394
- Partials 6048 7189 +1141
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
xiangfu0
approved these changes
Dec 31, 2024
xiangfu0
approved these changes
Dec 31, 2024
zeronerdzerogeekzerocool
pushed a commit
to zeronerdzerogeekzerocool/pinot
that referenced
this pull request
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calculating hash code of thrift
Expressionis super expensive, so we should reduce the hash computation as much as possible.This PR changes the
Set<Expression>toMap<String, Expression>to perform the deduplication of IN predicate values. The key is the string representation of the value, which is consistent of how predicates are handle on the server side (seeRequestContextUtils.getFilter().